Details
Details
- Reviewers
tyler-smith PiRK - Group Reviewers
Restricted Project - Maniphest Tasks
- T1693: Add more foreign currencies
- Commits
- rABCe4ef397e3c6c: [p2p] Small follow-ups to 21528
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- PR22618
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18066 Build 35954: Build Diff build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy Build 35953: arc lint + arc unit
Event Timeline
| doc/release-notes.md | ||
|---|---|---|
| 11 ↗ | (On Diff #32061) | I've never seen the worked "romour" used this way. It appears to be used like "gossip" but you use gossip later so maybe there's a difference I'm not getting? I don't see it in the codebase so if it's a synonym I think it'd be better to stick with "gossip", and if it's not we should maybe define it somewhere. |
Comment Actions
Consistently use "gossip" instead of "rumour". I don't have a good enough understanding of the difference in usage between these 2 words in english to prefer one over the other.
Also remove the PR number which is irrelevant in our release notes.