Page MenuHomePhabricator
Differential D1209

Add helper function for disabled opcodes
ClosedPublic
Actions

Authored by schancel on Mar 17 2018, 22:29.

Details

Reviewers
deadalnix
jasonbcox
movrcx
matiu
Group Reviewers
Restricted Project
Commits
rSTAGINGcb05fb4c2d8c: Add helper function for disabled opcodes
rABCcb05fb4c2d8c: Add helper function for disabled opcodes
Summary

Add IsOpcodeDisabled helper function to see if an opcode
is supposed to be disabled or not

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
areopcodedisabled
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2138
Build 2420: Bitcoin ABC Buildbot (legacy)
Build 2419: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 17 2018, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2018, 22:29
teamcity added a subscriber: teamcity.Mar 17 2018, 22:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3262.Mar 17 2018, 22:31

Add verbose returns so opcode diffs can merge independently.

schancel updated this revision to Diff 3263.Mar 17 2018, 22:32

Fix bloody whitespace

jasonbcox requested changes to this revision.Mar 17 2018, 22:32
jasonbcox added inline comments.
src/script/interpreter.cpp
310

Should be false, right?

This revision now requires changes to proceed.Mar 17 2018, 22:32
teamcity added a comment.Mar 17 2018, 22:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 17 2018, 22:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 17 2018, 22:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2138: Diff 3261.Mar 17 2018, 22:51
teamcity added a comment.Mar 17 2018, 22:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2139: Diff 3262.Mar 17 2018, 22:52
jasonbcox accepted this revision.Mar 17 2018, 22:58
jasonbcox added inline comments.
src/script/interpreter.cpp
310

nvm, these will be set to false as they're implemented.

This revision is now accepted and ready to land.Mar 17 2018, 22:58
teamcity added a comment.Mar 17 2018, 23:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2140: Diff 3263.Mar 17 2018, 23:08
Closed by commit rABCcb05fb4c2d8c: Add helper function for disabled opcodes (authored by schancel). · Explain WhyMar 18 2018, 01:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
70 lines

Diff 3261

View Options

src/script/interpreter.cpp

Loading...