Paths

Table of Contentst

Differential D11157

rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test
ClosedPublic
Actions

Authored by PiRK on Mar 11 2022, 09:21.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCef48cb3edde6: rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test

Summary

This concludes backport of core#19145 [3/3]

https://github.com/bitcoin/bitcoin/pull/19145/commits/0d3b2f643d7da3202c0a0e757539208c4aa7c450
https://github.com/bitcoin/bitcoin/pull/19145/commits/6ccc8fc067bf516cda7bc5d7d721945be5ac2003
https://github.com/bitcoin/bitcoin/pull/19145/commits/e987ae5a554c9952812746c29f2766bacea4b727

Depends on D11162

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18453
Build 36703: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 36702: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 11 2022, 09:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2022, 09:21

PiRK requested review of this revision.Mar 11 2022, 09:21

teamcity edited the summary of this revision. (Show Details)Mar 11 2022, 09:23

Harbormaster completed remote builds in B18453: Diff 32661.Mar 11 2022, 09:58

Fabien requested changes to this revision.Mar 11 2022, 13:30

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/node/coinstats.cpp
46	This method would benefit from taking a TxId directly. It's probably worth a refactor as I see the other methods all take an uint256 as well, despite working on transactions
54	Out of scope, but it would be a good idea to have a method for this and make it less opaque.
src/rpc/blockchain.cpp
1235	Can be static
1277	Does this deserve a release note ?

This revision now requires changes to proceed.Mar 11 2022, 13:30

Fabien mentioned this in D11156: refactor: Separate hash and stats calculation in coinstats.Mar 11 2022, 13:53

rebase on D11162, add a release note, make a function static, make ApplyHash takes a txid

PiRK edited the summary of this revision. (Show Details)Mar 11 2022, 17:12

PiRK added a parent revision: D11162: make ApplyHash and ApplyStats take a TxId.

Harbormaster completed remote builds in B18462: Diff 32672.Mar 11 2022, 17:28

Fabien accepted this revision.Mar 12 2022, 07:35

This revision is now accepted and ready to land.Mar 12 2022, 07:35

Closed by commit rABCef48cb3edde6: rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyMar 14 2022, 07:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCef48cb3edde6: rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test.

PiRK mentioned this in D14671: fuzz: Remove useless GetUTXOStats fuzz case.Oct 24 2023, 08:42

PiRK mentioned this in rABCc4c53baa3851: fuzz: Remove useless GetUTXOStats fuzz case.Oct 26 2023, 11:39

Revision Contents
Changeset List

Path

Size

src/

node/

1 line

26 lines

rpc/

29 lines

3 lines

19 lines

test/

functional/

feature_utxo_set_hash.py

92 lines

rpc_blockchain.py

15 lines

Diff 32661

src/node/coinstats.h

Loading...

src/node/coinstats.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

test/functional/feature_utxo_set_hash.py

Loading...

test/functional/rpc_blockchain.py

Loading...