Buildable 18532
Build 36859: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 36858: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 16 2022, 17:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2022, 17:42

PiRK requested review of this revision.Mar 16 2022, 17:42

teamcity edited the summary of this revision. (Show Details)Mar 16 2022, 17:42

PiRK edited the summary of this revision. (Show Details)Mar 16 2022, 17:44

Harbormaster completed remote builds in B18522: Diff 32768.Mar 16 2022, 17:58

Fabien requested changes to this revision.Mar 16 2022, 20:25

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
815 ↗	(On Diff #32768)	Then what's the point of this diff ?

This revision now requires changes to proceed.Mar 16 2022, 20:25

use active_chainstate in AcceptToMemoryPool(WithTime)

Harbormaster completed remote builds in B18532: Diff 32782.Mar 17 2022, 07:51

PiRK added a child revision: D11201: validation: Pass in chain to ::TestLockPointValidity.Mar 17 2022, 07:57

Fabien accepted this revision.Mar 17 2022, 08:00

This revision is now accepted and ready to land.Mar 17 2022, 08:00

Closed by commit rABCe01f4636abd4: validation: Pass in chainstate to ::AcceptToMemoryPool (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 11:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe01f4636abd4: validation: Pass in chainstate to ::AcceptToMemoryPool.

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

6 lines

net_processing.cpp

8 lines

node/

transaction.cpp

7 lines

rpc/

rawtransaction.cpp

2 lines

test/

txvalidation_tests.cpp

8 lines

txvalidationcache_tests.cpp

6 lines

validation_block_tests.cpp

3 lines

txmempool.cpp

4 lines

validation.h

8 lines

validation.cpp

9 lines

Diff 32782

View Options

src/bench/block_assemble.cpp

View Options

src/net_processing.cpp

View Options

src/node/transaction.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/txvalidation_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

validation: Pass in chainstate to ::AcceptToMemoryPoolClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32782

src/bench/block_assemble.cpp

src/net_processing.cpp

src/node/transaction.cpp

src/rpc/rawtransaction.cpp

src/test/txvalidation_tests.cpp

src/test/txvalidationcache_tests.cpp

src/test/validation_block_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

validation: Pass in chainstate to ::AcceptToMemoryPool
ClosedPublic
Actions

Revision Contents
Changeset List