Differential D11322

[avalanche] Send getavaaddr messages to the manually added nodes
ClosedPublic
Actions

Authored by Fabien on Apr 8 2022, 20:14.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe365dc8ab14e: [avalanche] Send getavaaddr messages to the manually added nodes

Summary

As per title, this makes it easier to test addresses propagation and make it possible to build private network. Only avalanche enabled peers are concerned.

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_getavaaddr_manual

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18761
Build 37313: Build Diff	build-diff · build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy · build-clang
Build 37312: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 8 2022, 20:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2022, 20:14

Fabien requested review of this revision.Apr 8 2022, 20:14

Harbormaster completed remote builds in B18761: Diff 33123.Apr 8 2022, 20:26

The concept and implementation look good. A few nits with the test.

test/functional/abc_p2p_getavaaddr.py
292	Unless I'm misunderstanding this part of the test this should say "not responding" right?
378	Should we clean this up?

This revision now requires changes to proceed.Apr 11 2022, 06:39

Fabien added inline comments.Apr 11 2022, 07:29

test/functional/abc_p2p_getavaaddr.py
292	Good catch
378	Indeed, it should not be commented out

Uncomment the tests and fix comment

Harbormaster completed remote builds in B18771: Diff 33140.Apr 11 2022, 07:49

tyler-smith accepted this revision.Apr 12 2022, 04:26

This revision is now accepted and ready to land.Apr 12 2022, 04:26

Closed by commit rABCe365dc8ab14e: [avalanche] Send getavaaddr messages to the manually added nodes (authored by Fabien). · Explain WhyApr 12 2022, 06:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe365dc8ab14e: [avalanche] Send getavaaddr messages to the manually added nodes.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

9 lines

test/

functional/

abc_p2p_getavaaddr.py

62 lines

Diff 33123

src/net_processing.cpp

Loading...

test/functional/abc_p2p_getavaaddr.py

Loading...