[avalanche] Create transaction vote records.
AbandonedPublic
Actions

Authored by Mengerian on Apr 20 2022, 13:14.

Details

Reviewers

Fabien
deadalnix
tyler-smith

Group Reviewers

Restricted Project

Summary

Tracks VoteRecords for txs in the Processor but does not yet do anything with them; just get the
pieces in place.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18847
Build 37484: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-clang · build-debug
Build 37483: arc lint + arc unit

Event Timeline

tyler-smith created this revision.Apr 20 2022, 13:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2022, 13:14

tyler-smith requested review of this revision.Apr 20 2022, 13:14

tyler-smith added a child revision: D11373: [avalanche] Send invs for known transactions..Apr 20 2022, 13:19

Harbormaster completed remote builds in B18847: Diff 33257.Apr 20 2022, 13:27

Fabien requested changes to this revision.Apr 21 2022, 08:35

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/processor.cpp
55	Just drop that for now since it does nothing, and add it back when needed
318	It's accepted if it's in the mempool

This revision now requires changes to proceed.Apr 21 2022, 08:35

Remove isAccepted contructor property and IsWorthPolling.

tyler-smith planned changes to this revision.Apr 27 2022, 10:58

tyler-smith added inline comments.

src/avalanche/processor.cpp
318	Will we not want to poll on any transactions that are not in the mempool?
318	nvm, didn't mean to submit this. Fixed the pattern.

Harbormaster completed remote builds in B18898: Diff 33329.Apr 27 2022, 11:05

Fix accidental change-stack cross-contamination.

Harbormaster completed remote builds in B18915: Diff 33358.May 1 2022, 04:35

There is pretty much the same code stamped 3 times in a row now. This is clearly an indication that it is time to stop piling up and go to the design board.

This revision now requires changes to proceed.May 1 2022, 20:52

Mengerian commandeered this revision.Jan 15 2024, 17:32

Mengerian abandoned this revision.

Mengerian added a reviewer: tyler-smith.