Paths

Table of Contentst

Differential D11415

[avalanche] Improve logging of the vote status update
ClosedPublic
Actions

Authored by Fabien on May 5 2022, 09:43.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC79c038dfd007: [avalanche] Improve logging of the vote status update

Summary

This makes the log message consistent between blocks and proofs.

Test Plan

ninja check-functional-extended

Run a quorum of bitcoind nodes and look at the log

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_improve_logging

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18971
Build 37704: Build Diff	lint-circular-dependencies · build-clang-tidy · build-diff · build-debug · build-without-wallet · build-clang
Build 37703: arc lint + arc unit

Event Timeline

Fabien created this revision.May 5 2022, 09:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 09:43

Fabien requested review of this revision.May 5 2022, 09:43

Harbormaster completed remote builds in B18943: Diff 33395.May 5 2022, 10:08

PiRK added a subscriber: PiRK.May 5 2022, 15:09

PiRK added inline comments.

src/net_processing.cpp
5147 ↗	(On Diff #33395)	Is it OK in C++17 to use `auto` for function parameters? Here it says C++20 https://en.cppreference.com/w/cpp/language/function_template#Abbreviated_function_template

PiRK accepted this revision.May 5 2022, 15:15

This revision is now accepted and ready to land.May 5 2022, 15:15

Fabien added inline comments.May 5 2022, 15:16

src/net_processing.cpp
5147 ↗	(On Diff #33395)	This is a generic lambda, a C++14 feature: https://en.cppreference.com/w/cpp/language/lambda

Rebase to remove the dependency

Fabien edited the summary of this revision. (Show Details)May 6 2022, 08:51

Fabien edited the test plan for this revision. (Show Details)

Fabien removed a parent revision: D11414: [avalanche] Rename the `Invalid` vote status for consistency with other status.

Harbormaster completed remote builds in B18971: Diff 33432.May 6 2022, 09:08

Closed by commit rABC79c038dfd007: [avalanche] Improve logging of the vote status update (authored by Fabien). · Explain WhyMay 6 2022, 09:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC79c038dfd007: [avalanche] Improve logging of the vote status update.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

37 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

2 lines

Diff 33432

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...