Page MenuHomePhabricator
Differential D11435

net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on May 6 2022, 15:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3e0b98aeda72: net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to…
Summary

Allows converting mapBlocksInFlight and g_last_tip_update from globals to member variables, and remove need to pass mempool or consensus params to methods.

This is a backport of core#20942 [4&5/9]
https://github.com/bitcoin/bitcoin/pull/20942/commits/a490f0a056456d683dd8ef6f89a5af1a13792118
https://github.com/bitcoin/bitcoin/pull/20942/commits/d44084883adcf00f50d3d5a9e0c88e3a0b276817

Note: consensusParams is not needed in our version of FindNextBlocksToDownload. Core uses it to test IsWitnessEneabled.

Depends on D11434

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 6 2022, 15:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2022, 15:51
PiRK requested review of this revision.May 6 2022, 15:51
teamcity edited the summary of this revision. (Show Details)May 6 2022, 15:51
PiRK updated this revision to Diff 33440.May 6 2022, 15:55

remove duplicated doxygen doc

PiRK added a child revision: D11436: net_processing: move FindTxForGetData and ProcessGetData to PeerManagerImpl.May 6 2022, 15:55
Harbormaster completed remote builds in B18975: Diff 33439.May 6 2022, 16:13
Harbormaster completed remote builds in B18976: Diff 33440.May 6 2022, 16:23
Fabien requested changes to this revision.May 9 2022, 09:54
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
771 ↗(On Diff #33440)

Still needed ?

This revision now requires changes to proceed.May 9 2022, 09:54
PiRK updated this revision to Diff 33450.May 9 2022, 14:15

remove unused chainParams parameter

Harbormaster completed remote builds in B18981: Diff 33450.May 9 2022, 14:53
Fabien accepted this revision.May 10 2022, 10:01
This revision is now accepted and ready to land.May 10 2022, 10:01
Closed by commit rABC3e0b98aeda72: net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to… (authored by PiRK). · Explain WhyMay 10 2022, 15:13
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3e0b98aeda72: net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to….
PiRK mentioned this in D11443: Remove redundant lock annotations in net processing.May 11 2022, 10:08
PiRK mentioned this in rABC2e57141cb11d: Remove redundant lock annotations in net processing.May 11 2022, 11:45

Revision Contents
Changeset List

PathSize
src/
135 lines

Diff 33458

View Options

src/net_processing.cpp

Loading...