[Cashtab] [Chronik Websocket Notifications] [Part 3] Subscribe to Hash160s
ClosedPublic
Actions

Authored by bytesofman on May 30 2022, 17:32.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCe6faab0c5eab: [Cashtab] [Chronik Websocket Notifications] [Part 3] Subscribe to Hash160s

Summary

T2447

Depends on D11531

Part 3 of stacked diff for implementing chronik websocket connections into Cashtab.

This diff uses the getHashArrayFromWallet function defined in Part 2 to obtain + subscribe to the correct addresses.

Test Plan

npm start
Open dev console
Observe subscription to wallet's hash160s through websocket.
Send a tx to the wallet and observe a msg in the console.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

connect-to-chronik-ws

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19181
Build 38110: Build Diff	cashtab-tests
Build 38109: arc lint + arc unit

Event Timeline

bytesofman created this revision.May 30 2022, 17:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2022, 17:32

bytesofman requested review of this revision.May 30 2022, 17:32

Harbormaster completed remote builds in B19181: Diff 33724.May 30 2022, 17:35

bytesofman mentioned this in D11530: [Cashtab] [Chronik Websocket Notifications] [Part 1] Connect to websocket.May 31 2022, 16:37

bytesofman edited the summary of this revision. (Show Details)May 31 2022, 17:50

bytesofman added a parent revision: D11531: [Cashtab] [Chronik Websocket Notifications] [Part 2] Get Hash160s from wallet.

bytesofman added a child revision: D11535: [Cashtab] [Chronik Websocket Notifications] [Part 4] Unsubscribe to Hash160s when active wallet changes.

emack requested changes to this revision.Jun 1 2022, 02:19

emack added a subscriber: emack.

emack added inline comments.

web/cashtab/src/hooks/useWallet.js
956	Based on a simple send tx to the wallet, I'm seeing uncaught exceptions from the ws endpoint in the console below. Needs to be wrapped in a try/catch block.

This revision now requires changes to proceed.Jun 1 2022, 02:19

emack mentioned this in D11535: [Cashtab] [Chronik Websocket Notifications] [Part 4] Unsubscribe to Hash160s when active wallet changes.Jun 1 2022, 02:43

bytesofman added a subscriber: tobias_ruck.Jun 1 2022, 23:47

bytesofman added inline comments.

web/cashtab/src/hooks/useWallet.js
956	I am able to recreate this. However, this is not related to the subscriptions or unsubscriptions -- it's something to do with the message event handler. I only get this on the "confirmed" messages, not the "seen" messages. Will check with @tobias_ruck to see if this is on chronik end. Separately, good catch, I have not configured these notifications to ignore the "confirmed" messages. Will get a task up for that.

With D11554 up, and @tobias_ruck confirming that this error msg is due to this version of chronik-client not handling "block found" messages, I think this is okay to land. The error msg is annoying on this version but does not impact performance.

emack accepted this revision.Jun 6 2022, 23:45

This revision is now accepted and ready to land.Jun 6 2022, 23:45

Rebase

Harbormaster completed remote builds in B19270: Diff 33840.Jun 7 2022, 01:19

emack mentioned this in D11541: [Cashtab] [Chronik Websocket Notifications] [Part 10] If ws connection active, hide api notifications.Jun 7 2022, 06:59

Closed by commit rABCe6faab0c5eab: [Cashtab] [Chronik Websocket Notifications] [Part 3] Subscribe to Hash160s (authored by bytesofman). · Explain WhyJun 7 2022, 21:06

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCe6faab0c5eab: [Cashtab] [Chronik Websocket Notifications] [Part 3] Subscribe to Hash160s.