Page MenuHomePhabricator
Differential D1258

[secp256k1] Make sure we get the requested number of bytes from /dev/urandom
ClosedPublic
Actions

Authored by deadalnix on Apr 8 2018, 15:53.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom
rABC2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom
Summary

Backport PR499 from practicalswift

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secpdevurandom
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2261
Build 2664: Bitcoin ABC Buildbot (legacy)
Build 2663: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 8 2018, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2018, 15:53
teamcity added a subscriber: teamcity.Apr 8 2018, 18:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 8 2018, 18:34

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2261: Diff 3426.Apr 8 2018, 18:34
schancel accepted this revision.Apr 9 2018, 04:25
This revision is now accepted and ready to land.Apr 9 2018, 04:25
sickpig added subscribers: tomtomtom7, sickpig.Apr 9 2018, 12:46

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

tomtomtom7 added a comment.Apr 9 2018, 13:01
In D1258#24894, @sickpig wrote:

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

The D1072 UTXO patches certainly deviate from upstream as it is not accepted there. But I would think you can still pull updates using a subtree if needed? The deviation is mostly new files and conflicts are unlikely.

Closed by commit rABC2fd74f214029: [secp256k1] Make sure we get the requested number of bytes from /dev/urandom (authored by deadalnix). · Explain WhyApr 9 2018, 15:23
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
2 lines

Diff 3426

View Options

src/secp256k1/src/tests.c

Loading...