Paths

Table of Contentst

Differential D12145

[Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived
ClosedPublic
Actions

Authored by bytesofman on Oct 4 2022, 23:25.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC5f508e303cc6: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived

Summary

T2447

Depends on D12144

Remove two legacy parameters and replace them with xecAmount parameter.

Test Plan

Review unit test changes and npm test
npm start, send and receive XEC txs, see they are parsed correctly in tx history

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 4 2022, 23:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 23:26

bytesofman requested review of this revision.Oct 4 2022, 23:26

Harbormaster completed remote builds in B20352: Diff 35424.Oct 4 2022, 23:28

bytesofman added a child revision: D12146: [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param.Oct 4 2022, 23:31

emack accepted this revision.Oct 6 2022, 00:16

This revision is now accepted and ready to land.Oct 6 2022, 00:16

Closed by commit rABC5f508e303cc6: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived (authored by bytesofman). · Explain WhyOct 6 2022, 13:49

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5f508e303cc6: [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

Tx.js

18 lines

utils/

__tests__/

chronik.test.js

26 lines

chronik.js

4 lines

Diff 35489

View Options

web/cashtab/src/components/Home/Tx.js

View Options

web/cashtab/src/utils/tests/chronik.test.js

View Options

web/cashtab/src/utils/chronik.js

[Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceivedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35489

web/cashtab/src/components/Home/Tx.js

web/cashtab/src/utils/__tests__/chronik.test.js

web/cashtab/src/utils/chronik.js

[Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/utils/tests/chronik.test.js