rpc: more detailed errors for getblockfrompeer
ClosedPublic
Actions

Authored by PiRK on Dec 1 2022, 13:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC46ff54fbdee6: rpc: more detailed errors for getblockfrompeer

Summary

This is a partial backport of core#23706
https://github.com/bitcoin/bitcoin/pull/23706/commits/34d5399211eeb61e7e7961c301fb2ddea8aa3f6a

Depends on D12719

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20295

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21300
Build 42250: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 42249: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 1 2022, 13:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2022, 13:08

PiRK requested review of this revision.Dec 1 2022, 13:08

teamcity edited the summary of this revision. (Show Details)Dec 1 2022, 13:08

Harbormaster completed remote builds in B21300: Diff 36879.Dec 1 2022, 13:10

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[383/529] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[384/529] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[385/529] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[386/529] Linking CXX static library src/libcommon.a
[387/529] Linking CXX static library src/libscript.a
[388/529] Linking CXX static library src/libbitcoinconsensus.a
[389/529] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[390/529] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c ../../src/rpc/net.cpp
In file included from ../../src/rpc/net.cpp:14:
../../src/./net_processing.h:65:20: error: parameter 'pindex' not found in the function declaration [-Werror,-Wdocumentation]
     * @param[in]  pindex   The block index
                   ^~~~~~
../../src/./net_processing.h:65:20: note: did you mean 'block_index'?
     * @param[in]  pindex   The block index
                   ^~~~~~
                   block_index
1 error generated.
[391/529] Linking CXX shared library src/libbitcoinconsensus.so.0.26.8
[392/529] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[393/529] Linking CXX executable src/bitcoin-cli
[394/529] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/server_util.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/server_util.cpp.o -MF src/CMakeFiles/server.dir/rpc/server_util.cpp.o.d -o src/CMakeFiles/server.dir/rpc/server_util.cpp.o -c ../../src/rpc/server_util.cpp
In file included from ../../src/rpc/server_util.cpp:7:
../../src/./net_processing.h:65:20: error: parameter 'pindex' not found in the function declaration [-Werror,-Wdocumentation]
     * @param[in]  pindex   The block index
                   ^~~~~~
../../src/./net_processing.h:65:20: note: did you mean 'block_index'?
     * @param[in]  pindex   The block index
                   ^~~~~~
                   block_index
1 error generated.
[395/529] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/test/util/setup_common.cpp:19:
../../src/./net_processing.h:65:20: error: parameter 'pindex' not found in the function declaration [-Werror,-Wdocumentation]
     * @param[in]  pindex   The block index
                   ^~~~~~
../../src/./net_processing.h:65:20: note: did you mean 'block_index'?
     * @param[in]  pindex   The block index
                   ^~~~~~
                   block_index
1 error generated.
[396/529] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[397/529] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[398/529] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[399/529] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[400/529] Linking CXX executable src/bitcoin-tx
[401/529] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[402/529] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[403/529] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[404/529] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[405/529] Linking CXX static library src/wallet/libwallet.a
[406/529] Linking CXX static library src/wallet/libwallet-tool.a
[407/529] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

rebase after fixing doxygen in D12716

PiRK added a child revision: D12721: rpc: use peer_id, blockhash for FetchBlock.Dec 1 2022, 13:32

Harbormaster completed remote builds in B21304: Diff 36883.Dec 1 2022, 13:43

Fabien accepted this revision.Dec 1 2022, 14:54

This revision is now accepted and ready to land.Dec 1 2022, 14:54

rebase

Harbormaster completed remote builds in B21315: Diff 36895.Dec 1 2022, 17:21

Closed by commit rABC46ff54fbdee6: rpc: more detailed errors for getblockfrompeer (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by PiRK). · Explain WhyDec 3 2022, 07:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC46ff54fbdee6: rpc: more detailed errors for getblockfrompeer.