style-only: No need for std::pair for vSortedByHeight
ClosedPublic
Actions

Authored by PiRK on Jan 23 2023, 10:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcecbcba200c8: style-only: No need for std::pair for vSortedByHeight

Summary

...since the height information in already in CBlockIndex* and we can
use an easy custom sorter.

This is a partial backport of core#24515
https://github.com/bitcoin/bitcoin/pull/24515/commits/42e56d9b188f97c077ed2269e24acc0be35ece17

Also includes a comment removal from https://github.com/bitcoin/bitcoin/pull/24515/commits/3bbb6fea051f4e19bd2448e401a6c4e9b4cc7a41
The rest of this commit is already done in Bitcoin ABC (review of D12993 and D12994)

Depends on D13020

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21811
Build 43257: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 43256: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 23 2023, 10:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 10:13

PiRK requested review of this revision.Jan 23 2023, 10:13

teamcity edited the summary of this revision. (Show Details)Jan 23 2023, 10:13

PiRK added a child revision: D13022: Only load BlockMan in BlockMan member functions.Jan 23 2023, 10:14

Harbormaster completed remote builds in B21811: Diff 37630.Jan 23 2023, 10:29

Fabien accepted this revision.Jan 23 2023, 14:12

This revision is now accepted and ready to land.Jan 23 2023, 14:12

Closed by commit rABCcecbcba200c8: style-only: No need for std::pair for vSortedByHeight (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 23 2023, 15:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcecbcba200c8: style-only: No need for std::pair for vSortedByHeight.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.cpp

17 lines

Diff 37630

View Options

style-only: No need for std::pair for vSortedByHeightClosedPublicActions