Page MenuHomePhabricator
Differential D1360

Remove support for `-sendfreetransactions`
ClosedPublic
Actions

Authored by schancel on May 2 2018, 23:48.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6d85f0424486: Remove support for `-sendfreetransactions`
rABC6d85f0424486: Remove support for `-sendfreetransactions`
Summary

As per title

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-send-free
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2523
Build 3166: Bitcoin ABC Buildbot (legacy)
Build 3165: arc lint + arc unit

Event Timeline

schancel created this revision.May 2 2018, 23:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2018, 23:48
teamcity added a subscriber: teamcity.May 2 2018, 23:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 00:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2479: Diff 3735.May 3 2018, 00:08
deadalnix requested changes to this revision.May 3 2018, 01:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.h
42 ↗(On Diff #3735)

It's extern, there is a declaration somewhere to delete.

This revision now requires changes to proceed.May 3 2018, 01:04
schancel updated this revision to Diff 3739.May 3 2018, 01:10

Derp

schancel updated this revision to Diff 3740.May 3 2018, 01:12

Add note to release notes

teamcity added a comment.May 3 2018, 01:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 01:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 3 2018, 01:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2482: Diff 3739.May 3 2018, 01:30
teamcity added a comment.May 3 2018, 01:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2483: Diff 3740!May 3 2018, 01:33
jasonbcox accepted this revision.May 3 2018, 21:19
jasonbcox added a subscriber: jasonbcox.

LGTM

deadalnix requested changes to this revision.May 4 2018, 16:19
deadalnix added inline comments.
src/wallet/wallet.cpp
46 ↗(On Diff #3740)

I assume DEFAULT_SEND_FREE_TRANSACTIONS is to be deleted as well.

This revision now requires changes to proceed.May 4 2018, 16:19
schancel updated this revision to Diff 3788.May 6 2018, 04:50

Remove DEFAULT_SEND_FREE_TRANSACTIONS as well

teamcity added a comment.May 6 2018, 04:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 6 2018, 05:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2523: Diff 3788.May 6 2018, 05:14
deadalnix accepted this revision.May 6 2018, 22:57
This revision is now accepted and ready to land.May 6 2018, 22:57
Closed by commit rABC6d85f0424486: Remove support for `-sendfreetransactions` (authored by schancel). · Explain WhyMay 7 2018, 20:25
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D1387: Remove unused fAllowFree variable from coincontrolwallet.cpp.May 8 2018, 23:57
schancel mentioned this in rABC194ccf30bd90: Remove unused fAllowFree variable from coincontrolwallet.cpp.May 9 2018, 07:04
schancel mentioned this in rSTAGING194ccf30bd90: Remove unused fAllowFree variable from coincontrolwallet.cpp.Sep 27 2018, 18:48
markblundeberg mentioned this in D4745: remove priority free transactions mechanism (currently off by default).Dec 17 2019, 07:54
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABCfbe0046ba2e4: remove priority free transactions mechanism (currently off by default).Dec 18 2019, 01:21
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGfbe0046ba2e4: remove priority free transactions mechanism (currently off by default).Apr 7 2020, 22:08

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
qt/
6 lines
wallet/
3 lines
16 lines

Diff 3788

View Options

doc/release-notes.md

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...