Page MenuHomePhabricator

Remove support for `-sendfreetransactions`
ClosedPublic

Authored by schancel on May 2 2018, 23:48.

Details

Summary

As per title

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-send-free
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2523
Build 3166: Bitcoin ABC Buildbot (legacy)
Build 3165: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 3 2018, 01:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.h
42 ↗(On Diff #3735)

It's extern, there is a declaration somewhere to delete.

This revision now requires changes to proceed.May 3 2018, 01:04

Add note to release notes

deadalnix requested changes to this revision.May 4 2018, 16:19
deadalnix added inline comments.
src/wallet/wallet.cpp
46 ↗(On Diff #3740)

I assume DEFAULT_SEND_FREE_TRANSACTIONS is to be deleted as well.

This revision now requires changes to proceed.May 4 2018, 16:19

Remove DEFAULT_SEND_FREE_TRANSACTIONS as well

This revision is now accepted and ready to land.May 6 2018, 22:57
This revision was automatically updated to reflect the committed changes.