Page MenuHomePhabricator
Differential D13136

[RPC] Remove deprecated fee-related mempool entry fields
ClosedPublic
Actions

Authored by Fabien on Feb 16 2023, 15:41.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC0599abc7c673: [RPC] Remove deprecated fee-related mempool entry fields
Summary

They have all been deprecated for very long and replaced by the fees object field that provides the same data with better encpsulation.

Depends on D13135.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_deprecated_mempool_data
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22002
Build 43639: Build Diffbuild-without-wallet · build-clang-tidy · lint-circular-dependencies · build-debug · build-diff · build-clang
Build 43638: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 16 2023, 15:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2023, 15:41
Fabien requested review of this revision.Feb 16 2023, 15:41
Fabien planned changes to this revision.Feb 16 2023, 15:54
PiRK added a subscriber: PiRK.Feb 16 2023, 15:54
PiRK added inline comments.
doc/release-notes.md
9 ↗(On Diff #37914)

were deprecated for long seems wrong (to be confirmed by a native english speaker). I would have used have been deprecated for a long time instead

Harbormaster completed remote builds in B22001: Diff 37914.Feb 16 2023, 15:58
Fabien updated this revision to Diff 37915.Feb 16 2023, 16:58

Add the missing files

Harbormaster completed remote builds in B22002: Diff 37915.Feb 16 2023, 17:16
Fabien updated this revision to Diff 37923.Feb 16 2023, 20:04

Rephrase the release notes

Harbormaster completed remote builds in B22010: Diff 37923.Feb 16 2023, 20:26
PiRK accepted this revision.Feb 17 2023, 08:40
This revision is now accepted and ready to land.Feb 17 2023, 08:40
PiRK added a child revision: D13137: mempool: Remove ancestor/descendant related stats from RPC.Feb 17 2023, 10:20
Closed by commit rABC0599abc7c673: [RPC] Remove deprecated fee-related mempool entry fields (authored by Fabien). · Explain WhyFeb 17 2023, 10:34
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0599abc7c673: [RPC] Remove deprecated fee-related mempool entry fields.

Revision Contents
Changeset List

PathSize
doc/
6 lines
src/
rpc/
15 lines
test/
functional/
33 lines
10 lines

Diff 37915

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/mempool_packages.py

Loading...
View Options

test/functional/rpc_fundrawtransaction.py

Loading...