Page MenuHomePhabricator

mempool: Remove ancestor/descendant related stats from RPC
ClosedPublic

Authored by Fabien on Feb 16 2023, 17:13.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC12985ae1b027: mempool: Remove ancestor/descendant related stats from RPC
Summary
The mempool quadratic stats themselves will soon be removed in a future commit.
However, we are removing them from RPC now in this commit to keep things
manageable.

This commit removes the following stats from RPC:

- "ancestor", "descendant", "descendantcount", "descendantsize", "descendantfees",
  "ancestorcount", "ancestorsize", "ancestorfees"
- RPC's affected: `getrawmempool true`, `getmempoolancestors`,
  `getmempooldescendants`, `getmempoolentry`

Port of bchn#1129.

Depends on D13133 and D13136.

Instead of removing the fields, we deprecate them for backward compatibility.
The mempool_packages.py and mempool_updatefromblock.py tests are kept
unchanged with the deprecation option so we are still testing the feature.
It's also easier than adding the cases to the deprecated RPCs functional test.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Feb 16 2023, 17:13
PiRK accepted this revision.EditedFeb 17 2023, 10:19
PiRK added a subscriber: PiRK.

There is some code duplication in MempoolEntryDescription but that's OK with me as the deprecated fields will be deleted later.

This revision is now accepted and ready to land.Feb 17 2023, 10:19