Page MenuHomePhabricator
Differential D13290

[Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 11 2023, 09:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb2645957168f: [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork`
Summary

Walks back the chain until it finds a common ancestor.

Depends on D13289.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t chronikbridge_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-find-fork
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22358
Build 44342: Build Diffbuild-chronik
Build 44341: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 11 2023, 09:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 09:10
tobias_ruck requested review of this revision.Mar 11 2023, 09:10
Harbormaster completed remote builds in B22355: Diff 38424.Mar 11 2023, 09:23
Fabien accepted this revision.Mar 11 2023, 09:34
This revision is now accepted and ready to land.Mar 11 2023, 09:34
tobias_ruck updated this revision to Diff 38426.Mar 11 2023, 10:47

rebase on chronik-get-ancestor

Harbormaster completed remote builds in B22357: Diff 38426.Mar 11 2023, 11:04
tobias_ruck updated this revision to Diff 38427.Mar 11 2023, 12:47

Move find_fork test after test_lookup_block_index

Harbormaster completed remote builds in B22358: Diff 38427.Mar 11 2023, 12:58
tobias_ruck added a child revision: D13291: [Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex`.Mar 11 2023, 13:00
Closed by commit rABCb2645957168f: [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork` (authored by tobias_ruck). · Explain WhyMar 13 2023, 11:47
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCb2645957168f: [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork`.

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
6 lines
chronik-cpp/
2 lines
10 lines
test/
25 lines

Diff 38427

View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/test/chronikbridge_tests.cpp

Loading...