Page MenuHomePhabricator
Differential D1381

Add integration tests for sighashtype boundary condition
ClosedPublic
Actions

Authored by jasonbcox on May 7 2018, 14:50.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING99bc4b87cf4b: Add integration tests for sighashtype boundary condition
rABC99bc4b87cf4b: Add integration tests for sighashtype boundary condition
Summary

Added cases for sighashtype with 0x20

Test Plan

make check
then copied the generated tests to script_tests.json and ran make check again to verify.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tests-final-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2569
Build 3255: Bitcoin ABC Buildbot (legacy)
Build 3254: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2018, 14:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2018, 14:50
jasonbcox edited the test plan for this revision. (Show Details)May 7 2018, 14:52
teamcity added a subscriber: teamcity.May 7 2018, 14:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox edited the test plan for this revision. (Show Details)May 7 2018, 14:52
deadalnix requested changes to this revision.May 7 2018, 15:10
deadalnix added inline comments.
src/test/data/script_tests.json
64 ↗(On Diff #3802)

There is a section in that file for generated tests.

src/test/script_tests.cpp
431 ↗(On Diff #3802)

This is already tested.

449 ↗(On Diff #3802)

Put comment on their own line.

462 ↗(On Diff #3802)

dito

476 ↗(On Diff #3802)

dito

This revision now requires changes to proceed.May 7 2018, 15:10
teamcity added a comment.May 7 2018, 15:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2534: Diff 3802.May 7 2018, 15:16
jasonbcox updated this revision to Diff 3859.May 9 2018, 21:05

Removed redundant tests and cleaned up comments

teamcity added a comment.May 9 2018, 21:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 9 2018, 21:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2569: Diff 3859.May 9 2018, 21:30
deadalnix requested changes to this revision.May 10 2018, 00:12
deadalnix added inline comments.
src/test/script_tests.cpp
449

Can you reorder this to be located close to other test case that check similar pieces of code ?

926

Here

This revision now requires changes to proceed.May 10 2018, 00:12
jasonbcox updated this revision to Diff 3869.May 10 2018, 01:28

Moved to location in the code more relative to similar tests and added more informative test messages.

teamcity added a comment.May 10 2018, 01:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix accepted this revision.May 10 2018, 01:36
This revision is now accepted and ready to land.May 10 2018, 01:36
teamcity added a comment.May 10 2018, 01:53

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2574: Diff 3869.May 10 2018, 01:53
Closed by commit rABC99bc4b87cf4b: Add integration tests for sighashtype boundary condition (authored by jasonbcox). · Explain WhyMay 10 2018, 01:53
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D1411: Added script integration test intructions to developer-notes.May 14 2018, 02:54
jasonbcox mentioned this in rABCa317a4194fc2: Added script integration test intructions to developer-notes.May 21 2018, 22:08
jasonbcox mentioned this in rSTAGINGa317a4194fc2: Added script integration test intructions to developer-notes.Sep 27 2018, 18:49

Revision Contents
Changeset List

PathSize
src/
test/
data/
28 lines
33 lines

Diff 3859

View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/script_tests.cpp

Loading...