Page MenuHomePhabricator
Differential D13351

[alias-server] rename function getAllAliasTxs to getAliasTxs
AbandonedPublic
Actions

Authored by bytesofman on Mar 16 2023, 12:16.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

T2966

Moving toward alias processing of unprocessed txs only. Rename function getAllAliasTxs to getAliasTxs. This function will take any arbitrary array of tx history and return alias txs, it does not need the full history.

Test Plan

grep -r getAllAliasTxs . and no output
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
process-only-unprocessed-txs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22481
Build 44587: Build Diff
Build 44586: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 16 2023, 12:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2023, 12:16
bytesofman requested review of this revision.Mar 16 2023, 12:16
Harbormaster completed remote builds in B22481: Diff 38623.Mar 16 2023, 12:16
bytesofman added a child revision: D13353: [alias-server] Determine valid aliases from set of unprocessed txs and array of existing valid aliases.Mar 16 2023, 13:44
emack accepted this revision.Mar 18 2023, 02:35
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/websocket.js
124

update to getAliasTxs

This revision is now accepted and ready to land.Mar 18 2023, 02:35
emack added a comment.Mar 18 2023, 02:48

note commenting nit

bytesofman updated this revision to Diff 38951.Mar 27 2023, 21:29

rebase

Harbormaster completed remote builds in B22745: Diff 38951.Mar 27 2023, 21:29
bytesofman abandoned this revision.Mar 30 2023, 15:56
PiRK added a child revision: D13552: scripts: add MACHO NX check to security-check.py.Apr 4 2023, 09:19
PiRK removed a child revision: D13552: scripts: add MACHO NX check to security-check.py.Apr 4 2023, 13:41

Revision Contents
Changeset List

PathSize
web/
alias-server/
2 lines
scripts/
4 lines
test/
6 lines
20 lines

Diff 38623

View Options

web/alias-server/alias.js

Loading...
View Options

web/alias-server/scripts/generateMocks.js

Loading...
View Options

web/alias-server/test/alias.js

Loading...
View Options

web/alias-server/websocket.js

Loading...