Differential D1427

Fix a bunch of clang warnings.
ClosedPublic
Actions

Authored by schancel on May 17 2018, 03:42.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING517121b64bf9: Fix a bunch of clang warnings.
rABC517121b64bf9: Fix a bunch of clang warnings.

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

warnings

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2598
Build 3310: Bitcoin ABC Buildbot (legacy)
Build 3309: arc lint + arc unit

Event Timeline

schancel created this revision.May 17 2018, 03:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2018, 03:42

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2598: Diff 3906!May 17 2018, 03:57

jasonbcox accepted this revision.May 19 2018, 05:08

This revision is now accepted and ready to land.May 19 2018, 05:08

Closed by commit rABC517121b64bf9: Fix a bunch of clang warnings. (authored by schancel). · Explain WhyMay 21 2018, 20:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bench/

crypto_hash.cpp

4 lines

qt/

paymentserver.cpp

6 lines

seeder/

bitcoin.cpp

2 lines

test/

amount_tests.cpp

2 lines

monolith_opcodes.cpp

4 lines

test_bitcoin_fuzzy.cpp

4 lines

txdb.cpp

2 lines

Diff 3906

View Options

src/bench/crypto_hash.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/test/amount_tests.cpp

View Options

src/test/monolith_opcodes.cpp

View Options

src/test/test_bitcoin_fuzzy.cpp

View Options

Fix a bunch of clang warnings.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3906

src/bench/crypto_hash.cpp

src/qt/paymentserver.cpp

src/seeder/bitcoin.cpp

src/test/amount_tests.cpp

src/test/monolith_opcodes.cpp

src/test/test_bitcoin_fuzzy.cpp

src/txdb.cpp

Fix a bunch of clang warnings.
ClosedPublic
Actions

Revision Contents
Changeset List