Page MenuHomePhabricator

[Cashtab] Move directory out of web and to top level
ClosedPublic

Authored by bytesofman on Apr 4 2023, 21:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC64077793ebd5: [Cashtab] Move directory out of web and to top level
Summary

T3067

Cashtab is a large and complex application showcasing many features of other ecash dependencies and libraries. Though a web wallet, it isn't really a website. It's also more than just another app.

This diff moves Cashtab to its own top level directory as part of a planned monorepo directory organization process.

Test Plan
  • Confirm this diff alters no files in the cashtab/ directory
  • Confirm .arclint is updated appropriately with new dir info
  • Confirm build-configurations.yml is updated appropriately with new dir info
  • Make sure CI still works on unit tests (call bot token)
  • Make sure deployment paths are updated before landing

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-to-top-level
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22980
Build 45580: Build Diffcashtab-tests
Build 45579: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Apr 5 2023, 09:23
Fabien added a subscriber: Fabien.

There are a few remaining occurrences of web/cashtab in the repo (in several readme). you can find them all by calling git grep "web/cashtab" from the root of the repo

This revision now requires changes to proceed.Apr 5 2023, 09:23

Update links in ecashjs-lib readme for move

There are a few remaining occurrences of web/cashtab in the repo (in several readme). you can find them all by calling git grep "web/cashtab" from the root of the repo

Patched the README refs in ecashjs-lib. Two occurrences remain but these are related to web/cashtab-components which is not yet moved

There is one more

cashtab/README.md
70
This revision is now accepted and ready to land.Apr 5 2023, 12:33