Page MenuHomePhabricator
Differential D1439

Use TxId in GetTransaction and AccessByTxid
ClosedPublic
Actions

Authored by deadalnix on May 22 2018, 19:59.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING79957fcd93c0: Use TxId in GetTransaction and AccessByTxid
rABC79957fcd93c0: Use TxId in GetTransaction and AccessByTxid
Summary

As per title.

Depends on D1437

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coinstxid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2613
Build 3340: Bitcoin ABC Buildbot (legacy)
Build 3339: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 22 2018, 19:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2018, 19:59
teamcity added a subscriber: teamcity.May 22 2018, 19:59

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 22 2018, 20:38

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2613: Diff 3936.May 22 2018, 20:38
jasonbcox requested changes to this revision.May 23 2018, 01:08
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/coins.cpp
136

'o' is a pretty aweful name. Can we call this 'output' instead?

This revision now requires changes to proceed.May 23 2018, 01:08
deadalnix updated this revision to Diff 3946.May 23 2018, 10:09

Update name as per request

teamcity added a comment.May 23 2018, 10:09

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2621: Diff 3946.May 23 2018, 10:48
teamcity added a comment.May 23 2018, 10:48

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 23 2018, 15:46
This revision is now accepted and ready to land.May 23 2018, 15:46
Closed by commit rABC79957fcd93c0: Use TxId in GetTransaction and AccessByTxid (authored by deadalnix). · Explain WhyMay 24 2018, 07:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
10 lines
4 lines
rpc/
4 lines
test/
6 lines
5 lines
8 lines

Diff 3936

View Options

src/coins.h

Loading...
View Options

src/coins.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...