Paths

Table of Contentst

Differential D13615

[herald] Rename unit test file
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 16:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcfccce08c090: [herald] Rename unit test file

Summary

T2972

Depends on D13614

It's ambiguous having two files both with the same name. This convention is helpful for the developer.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-refactor-stack

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23077
Build 45774: Build Diff	ecash-herald-tests
Build 45773: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 16:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 16:19

bytesofman requested review of this revision.Apr 7 2023, 16:19

Harbormaster completed remote builds in B23077: Diff 39402.Apr 7 2023, 16:27

bytesofman added a child revision: D13616: [herald] Unit tests for initializing websocket.Apr 7 2023, 16:35

Fabien accepted this revision.Apr 9 2023, 06:27

This revision is now accepted and ready to land.Apr 9 2023, 06:27

rebase

Harbormaster completed remote builds in B23156: Diff 39491.Apr 10 2023, 16:30

Closed by commit rABCcfccce08c090: [herald] Rename unit test file (authored by bytesofman). · Explain WhyApr 12 2023, 14:26

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCcfccce08c090: [herald] Rename unit test file.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

test/

parse.js

	parseTests.js
	parse.js

51 lines

Diff 39402

View Options

apps/ecash-herald/test/parse.js