Page MenuHomePhabricator
Differential D13627

[herald] Improve mocked chronik
ClosedPublic
Actions

Authored by bytesofman on Apr 8 2023, 12:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0f77bd39c5f3: [herald] Improve mocked chronik
Summary

T2972

Depends on D13625

Implements lessons learned about how to best mock chronik from unit tests.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-refactor-stack
Lint
Lint Errors
SeverityLocationCodeMessage
Errorapps/ecash-herald/test/mainTests.js:7ESLINTno-unused-vars
Unit
No Test Coverage
Build Status
Buildable 23098
Build 45816: Build Diffecash-herald-tests
Build 45815: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 8 2023, 12:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 12:07
bytesofman requested review of this revision.Apr 8 2023, 12:07
Harbormaster completed remote builds in B23098: Diff 39423.Apr 8 2023, 12:07
bytesofman updated this revision to Diff 39424.Apr 8 2023, 12:07

lint

Harbormaster completed remote builds in B23099: Diff 39424.Apr 8 2023, 12:08
bytesofman mentioned this in D13629: [alias-server] Implement better chronik mock.Apr 8 2023, 12:17
bytesofman added a child revision: D13639: [herald] Improve generateMocks script calling.Apr 8 2023, 17:03
Fabien requested changes to this revision.Apr 9 2023, 07:09
Fabien added a subscriber: Fabien.

This is looking much better, nice

apps/ecash-herald/src/main.js
15 ↗(On Diff #39424)

that looks like a debug leftover, remove

25 ↗(On Diff #39424)

dito

apps/ecash-herald/test/mocks/chronikMock.js
41 ↗(On Diff #39424)

remove

This revision now requires changes to proceed.Apr 9 2023, 07:09
bytesofman updated this revision to Diff 39488.Apr 10 2023, 16:24

Removing debug logs

Harbormaster completed remote builds in B23153: Diff 39488.Apr 10 2023, 16:25
bytesofman marked 3 inline comments as done.Apr 10 2023, 16:25
bytesofman updated this revision to Diff 39501.Apr 10 2023, 16:31

rebase

Harbormaster completed remote builds in B23166: Diff 39501.Apr 10 2023, 16:31
Fabien accepted this revision.Apr 10 2023, 18:57
This revision is now accepted and ready to land.Apr 10 2023, 18:57
bytesofman mentioned this in rABC3f6cecea132a: [alias-server] Implement better chronik mock.Apr 12 2023, 14:20
Closed by commit rABC0f77bd39c5f3: [herald] Improve mocked chronik (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0f77bd39c5f3: [herald] Improve mocked chronik.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
2 lines
test/
25 lines
8 lines
mocks/
101 lines
47 lines

Diff 39423

View Options

apps/ecash-herald/src/main.js

Loading...
View Options

apps/ecash-herald/test/eventsTests.js

Loading...
View Options

apps/ecash-herald/test/mainTests.js

Loading...
View Options

apps/ecash-herald/test/mocks/chronikMock.js

Loading...
View Options

apps/ecash-herald/test/websocketTests.js

Loading...