Page MenuHomePhabricator
Differential D1455

Drop minimum fee to 250sat/kb
ClosedPublic
Actions

Authored by schancel on May 25 2018, 07:18.

Details

Reviewers
Mengerian
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa05062890a9c: Drop minimum fee to 250sat/kb
rABCa05062890a9c: Drop minimum fee to 250sat/kb
Summary

As per title

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
drop-fee
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2697
Build 3506: Bitcoin ABC Buildbot (legacy)
Build 3505: arc lint + arc unit

Event Timeline

schancel created this revision.May 25 2018, 07:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2018, 07:18
teamcity added a subscriber: teamcity.May 25 2018, 07:19

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 3986.May 25 2018, 07:23

Rebase on D1378

teamcity added a comment.May 25 2018, 07:24

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 25 2018, 07:55

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2649: Diff 3983!May 25 2018, 07:55
Harbormaster failed remote builds in B2652: Diff 3986!
teamcity added a comment.May 25 2018, 07:56

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

schancel added a parent revision: D1378: Use a modified size for transaction minimum fee calculation..May 25 2018, 14:14
Mengerian accepted this revision as: Mengerian.May 26 2018, 22:15
Mengerian added a subscriber: Mengerian.

Macro lgtm:

This revision is now accepted and ready to land.May 26 2018, 22:15
deadalnix requested changes to this revision.May 27 2018, 12:05
deadalnix added a subscriber: deadalnix.

I don't think we should go anywhere there untill we are able to bill per UTXO and we have test for it.

This revision now requires changes to proceed.May 27 2018, 12:05
schancel added a comment.May 30 2018, 20:26

@deadalnix Correct, that's why that change is part of the stack.

deadalnix accepted this revision.Jun 4 2018, 14:43
This revision is now accepted and ready to land.Jun 4 2018, 14:43
schancel updated this revision to Diff 4055.Jun 4 2018, 22:20

Fix mempool_limit again. However, I think this is a faux-fix

teamcity added a comment.Jun 4 2018, 22:20

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 4 2018, 22:53

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2696: Diff 4055.Jun 4 2018, 22:53
schancel updated this revision to Diff 4056.Jun 4 2018, 23:08

Fix test.

teamcity added a comment.Jun 4 2018, 23:09

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2697: Diff 4056.Jun 4 2018, 23:41
teamcity added a comment.Jun 4 2018, 23:41

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Closed by commit rABCa05062890a9c: Drop minimum fee to 250sat/kb (authored by schancel). · Explain WhyJun 4 2018, 23:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
2 lines
test/
functional/
4 lines

Diff 4056

View Options

doc/release-notes.md

Loading...
View Options

src/validation.h

Loading...
View Options

test/functional/mempool_limit.py

Loading...