Process transactions in two loops in ConnectBlock instead of one.
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2018, 23:46.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc49548921c98: Process transactions in two loops in ConnectBlock instead of one.
rABCc49548921c98: Process transactions in two loops in ConnectBlock instead of one.

Summary

This is a first step toward getting rid of transaction ordering.

Depends on D1479

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

connectblockdualloop

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2711
Build 3534: Bitcoin ABC Buildbot (legacy)
Build 3533: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 6 2018, 23:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2018, 23:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2711: Diff 4078.Jun 7 2018, 00:19

deadalnix added a child revision: D1487: Remove topological ordering constraint from block starting Nov, 15 2018.Jun 7 2018, 08:51

jasonbcox added a subscriber: jasonbcox.Jun 7 2018, 22:52

jasonbcox added inline comments.

src/validation.cpp
428	Should be a separate diff, but we can let it slide since this diff is small enough anyway.
2243	Is this safe to remove? Is i == 0 always the coinbase tx?

deadalnix added inline comments.Jun 7 2018, 22:54

src/validation.cpp
428	Agreed on both counts.
2243	i = 0 is always the coinbase. This is a consensus rule.

jasonbcox accepted this revision.Jun 7 2018, 22:55

This revision is now accepted and ready to land.Jun 7 2018, 22:55

Closed by commit rABCc49548921c98: Process transactions in two loops in ConnectBlock instead of one. (authored by deadalnix). · Explain WhyJun 8 2018, 15:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

102 lines

Diff 4078

View Options

Process transactions in two loops in ConnectBlock instead of one.ClosedPublicActions