A parked chain behave pretty much like an invalid chain as far as chain selection goes, but having 2 different states will allow to reconsider parked chain in time.
Depends on D1466
Details
Details
- Reviewers
schancel jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING7878c6b91cac: Introduce the concept of parked chain.
rABC7878c6b91cac: Introduce the concept of parked chain.
Added test for the flag mechnery itself.
I was unable to find a proper way to test the change in FindMostWorkChain as nothign set the flag yet - so intergration test do not quite work - and the whole thing is so screwed up that unit testing is not really viable.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- parkedblock
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2729 Build 3570: Bitcoin ABC Buildbot (legacy) Build 3569: arc lint + arc unit
Event Timeline
Comment Actions
I'm not sure about this concept. I do not think about EBP as being a property of the block, but rather where the block lives? I.E. does your car isn't changing when you park it, it's just going into your garage. I understand right now there is a mapBlockIndex and a chainActive.
Is there any reason not to introduce a wrapper around chainActive that contains a set of CChains?
| src/validation.cpp | ||
|---|---|---|
| 5030 | Can I please ask you to add a doc comment about the purpose of this function? I have no idea how to evaluate if this is correct without knowing what this is supposed to do. | |
| src/validation.cpp | ||
|---|---|---|
| 5030 | CheckBlockIndex : Check the index of blocks. Does this really need a doc comment ? | |
| src/validation.cpp | ||
|---|---|---|
| 5030 | What does it mean to check the block index? I do not know, I cannot review this. | |