Page MenuHomePhabricator
Differential D8778

Make AnalyzePSBT next role calculation simple, correct
ClosedPublic
Actions

Authored by PiRK on Jan 4 2021, 17:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcf883509c9c0: Make AnalyzePSBT next role calculation simple, correct
Summary

Set next to"finalizer" when all inputs need finalizing
Note that this assumes that PSBT roles are a complete ordering, which for now and in the future seems to be a correct assumption.

This is a backport of Core PR18224

Test Plan

ninja && ninja check && test/functional/test_runner.py rpc_psbt

Check that before this patch to psbt.cpp the functional test fails because the "next" role is signer, and after this patch is has the correct "finalizer" value.

Diff Detail

Event Timeline

PiRK created this revision.Jan 4 2021, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2021, 17:03
PiRK requested review of this revision.Jan 4 2021, 17:03
PiRK planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)Jan 4 2021, 17:03
Harbormaster completed remote builds in B14554: Diff 26610.Jan 4 2021, 17:16
PiRK updated this revision to Diff 41905.Aug 23 2023, 07:18

rebase from hell, use the signed (non-finalized) psbt from rpc_psbt.json

PiRK edited the test plan for this revision. (Show Details)Aug 23 2023, 07:20
Harbormaster completed remote builds in B24825: Diff 41905.Aug 23 2023, 07:35
Fabien accepted this revision.Aug 23 2023, 08:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/psbt.cpp
91

size_t

This revision is now accepted and ready to land.Aug 23 2023, 08:26
Closed by commit rABCcf883509c9c0: Make AnalyzePSBT next role calculation simple, correct (authored by Gregory Sanders <gsanders87@gmail.com>, committed by PiRK). · Explain WhyAug 23 2023, 09:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCcf883509c9c0: Make AnalyzePSBT next role calculation simple, correct.

Revision Contents
Changeset List

PathSize
src/
node/
32 lines
test/
functional/
6 lines

Diff 41905

View Options

src/node/psbt.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...