Page MenuHomePhabricator

Make AnalyzePSBT next role calculation simple, correct
ClosedPublic

Authored by PiRK on Jan 4 2021, 17:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcf883509c9c0: Make AnalyzePSBT next role calculation simple, correct
Summary

Set next to"finalizer" when all inputs need finalizing
Note that this assumes that PSBT roles are a complete ordering, which for now and in the future seems to be a correct assumption.

This is a backport of Core PR18224

Test Plan

ninja && ninja check && test/functional/test_runner.py rpc_psbt

Check that before this patch to psbt.cpp the functional test fails because the "next" role is signer, and after this patch is has the correct "finalizer" value.

Event Timeline

PiRK requested review of this revision.Jan 4 2021, 17:03
PiRK planned changes to this revision.

rebase from hell, use the signed (non-finalized) psbt from rpc_psbt.json

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/psbt.cpp
91

size_t

This revision is now accepted and ready to land.Aug 23 2023, 08:26