Page MenuHomePhabricator
Differential D1554

Remove warning about block version.
Changes PlannedPublic
Actions

Authored by deadalnix on Jul 10 2018, 13:18.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Summary

Part of BIP9 deprecation.

Depends on D1546

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killbip9warning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2844
Build 3792: Bitcoin ABC Buildbot (legacy)
Build 3791: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2018, 13:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2018, 13:18
teamcity added a subscriber: teamcity.Jul 10 2018, 13:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4250.Jul 10 2018, 13:27

Remove unused variable

teamcity added a comment.Jul 10 2018, 13:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 13:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2831: Diff 4249!Jul 10 2018, 13:59
teamcity added a comment.Jul 10 2018, 14:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2832: Diff 4250!Jul 10 2018, 14:09
jasonbcox accepted this revision.Jul 10 2018, 14:58
This revision is now accepted and ready to land.Jul 10 2018, 14:58
deadalnix updated this revision to Diff 4267.Jul 10 2018, 23:12

Rebase

teamcity added a comment.Jul 10 2018, 23:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 23:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2844: Diff 4267!Jul 10 2018, 23:53
deadalnix planned changes to this revision.Jul 11 2018, 00:42

This is breaking forknotify.

markblundeberg added a subscriber: markblundeberg.Jun 24 2019, 18:34

See D3181 (fixes forknotify test failure) and D2788 . Do we need to get these translations removed as well?

Revision Contents
Changeset List

Diff 4267

View Options

src/qt/locale/bitcoin_cs.ts

Loading...
View Options

src/qt/locale/bitcoin_da.ts

Loading...
View Options

src/qt/locale/bitcoin_de.ts

Loading...
View Options

src/qt/locale/bitcoin_en.ts

Loading...
View Options

src/qt/locale/bitcoin_en_GB.ts

Loading...
View Options

src/qt/locale/bitcoin_es.ts

Loading...
View Options

src/qt/locale/bitcoin_es_ES.ts

Loading...
View Options

src/qt/locale/bitcoin_fr.ts

Loading...
View Options

src/qt/locale/bitcoin_it.ts

Loading...
View Options

src/qt/locale/bitcoin_ja.ts

Loading...
View Options

src/qt/locale/bitcoin_ko_KR.ts

Loading...
View Options

src/qt/locale/bitcoin_nl.ts

Loading...
View Options

src/qt/locale/bitcoin_pt_BR.ts

Loading...
View Options

src/qt/locale/bitcoin_pt_PT.ts

Loading...
View Options

src/qt/locale/bitcoin_ru.ts

Loading...
View Options

src/qt/locale/bitcoin_sk.ts

Loading...
View Options

src/qt/locale/bitcoin_sv.ts

Loading...
View Options

src/qt/locale/bitcoin_tr.ts

Loading...
View Options

src/qt/locale/bitcoin_zh_CN.ts

Loading...
View Options

src/qt/locale/bitcoin_zh_TW.ts

Loading...
View Options

src/validation.cpp

Loading...