Page MenuHomePhabricator

[test] Overhaul p2p_compactblocks.py
ClosedPublic

Authored by PiRK on Nov 29 2023, 08:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb483581db7cd: [test] Overhaul p2p_compactblocks.py
Summary

backport of core#15660 and partial backport of core#20799
https://github.com/bitcoin/bitcoin/pull/20799/commits/cba909eaf938a775a9bd2dd994d06aba175e8713

Note that in our codebase test_node, ex_softfork_node and old_node are identical, as we use only version 1 compactblocks and NODE_NETWORK is the default services for TestP2PConn. As a result some tests were duplicated for no good reason. Removing this duplication divides the test time by 2.

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK requested review of this revision.Nov 29 2023, 08:12

nits: make it clear that test_node and additional_test_node have no differences in services, remove a trailing comma

Fabien added a subscriber: Fabien.

Nice !

This revision is now accepted and ready to land.Nov 29 2023, 10:20
This revision was automatically updated to reflect the committed changes.