cpp
AbandonedPublic
Actions

Authored by jasonbcox on Jul 22 2018, 22:01.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Summary

Moving server.h/cpp for two reasons:

There is no server class in server.h, so the name is inaccurate.
I want to create an RPCServer class and use server.h as a plain header

without all of this existing garbage in it.

I know the "helpers" name is kind of lame, but it will need to be split up into separate
header files in the near future as the RPC refactor continues.

Depends on D1583.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpchelpers

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/httprpc.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 2917
Build 3938: Bitcoin ABC Buildbot (legacy)
Build 3937: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 22 2018, 22:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2018, 22:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2917: Diff 4368.Jul 22 2018, 22:43

Might abandon this revision after talking with Amaury regarding this design. Rather than moving everything to helpers, he recommends building up the new RPCServer API first such that RPCServer calls the legacy RPC functions, and then slowly migrate legacy code out to various headers or delete them as necessary.

jasonbcox abandoned this revision.Sep 4 2018, 22:31