Page MenuHomePhabricator
Differential D1603

Isolating MAX_COINBASE_SCRIPTSIG_SIZE
ClosedPublic
Actions

Authored by vermorel on Jul 26 2018, 14:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING48cd2fecb4ab: Isolating MAX_COINBASE_SCRIPTSIG_SIZE
rABC48cd2fecb4ab: Isolating MAX_COINBASE_SCRIPTSIG_SIZE
Summary

The constant MAX_COINBASE_SCRIPTSIG_SIZE was badly located in
'miner.cpp' and thus moved to 'consensus.h'. Furthermore, the
validation was relying on an inline magic number which is now
replaced by the constant.

Test Plan

Compile and run automated tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2969
Build 4036: Bitcoin ABC Buildbot (legacy)
Build 4035: arc lint + arc unit

Event Timeline

vermorel created this revision.Jul 26 2018, 14:11
Owners added a reviewer: Restricted Owners Package.Jul 26 2018, 14:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2018, 14:11
teamcity added a subscriber: teamcity.Jul 26 2018, 14:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2969: Diff 4437.Jul 26 2018, 14:56
teamcity added a comment.Jul 26 2018, 14:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jul 26 2018, 17:05
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/validation.cpp
487

clang-format should have formatted this.

This revision now requires changes to proceed.Jul 26 2018, 17:05
vermorel updated this revision to Diff 4438.Jul 26 2018, 17:09

Proper lint formatting.

vermorel added a comment.Jul 26 2018, 17:10

Sorry, I had not figured out the upgrade from clang-format-3.5 to clang-format-4.0. Thanks for your patience!

teamcity added a comment.Jul 26 2018, 17:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jul 26 2018, 17:12

likestamp

This revision is now accepted and ready to land.Jul 26 2018, 17:12
teamcity added a comment.Jul 26 2018, 17:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2970: Diff 4438.Jul 26 2018, 17:51
Closed by commit rABC48cd2fecb4ab: Isolating MAX_COINBASE_SCRIPTSIG_SIZE (authored by vermorel). · Explain WhyJul 31 2018, 20:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
consensus/
2 lines
2 lines
2 lines

Diff 4437

View Options

src/consensus/consensus.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/validation.cpp

Loading...