[electrum] add tests for BIP21 parsing and creation
ClosedPublic
Actions

Authored by PiRK on Jan 22 2024, 16:37.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC7937a5693797: [electrum] add tests for BIP21 parsing and creation

Summary

Add an op_return test case for TestParseURI and add a suite for create_URI.
The new test suite shows that currently special chars are not escaped for the op_return paramater. This will be fixed in a separate diff.

Depends on D15235

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26550
Build 52670: Build Diff	electrum-tests
Build 52669: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 22 2024, 16:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2024, 16:37

PiRK requested review of this revision.Jan 22 2024, 16:37

Harbormaster completed remote builds in B26550: Diff 44444.Jan 22 2024, 16:39

PiRK added a child revision: D15231: [electrum] escape special chars in URI for op_return message.Jan 22 2024, 16:39

PiRK mentioned this in D15229: [electrum] clean and add tests for BIP21.Jan 22 2024, 16:42

bytesofman accepted this revision.Jan 22 2024, 18:06

This revision is now accepted and ready to land.Jan 22 2024, 18:06

PiRK edited the summary of this revision. (Show Details)Jan 22 2024, 21:13

Closed by commit rABC7937a5693797: [electrum] add tests for BIP21 parsing and creation (authored by PiRK). · Explain WhyJan 23 2024, 07:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7937a5693797: [electrum] add tests for BIP21 parsing and creation.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_bip21.py

107 lines

Diff 44444

View Options

electrum/electrumabc/tests/test_bip21.py

[electrum] add tests for BIP21 parsing and creationClosedPublicActions