Improve handling of OP_RETURN parsing in Cashtab tx history by using the available getStackArray method from ecash-script.
Delete the now-unused parseOpReturn method and its associated tests and mocks.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC70a5b48b4769: [Cashtab] Use ecash-script lib for op return tx parsing
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- use-opreturn-lib
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26684 Build 52936: Build Diff cashtab-tests Build 52935: arc lint + arc unit
Event Timeline
| cashtab/package.json | ||
|---|---|---|
| 3 ↗ | (On Diff #44620) | ? |
| cashtab/package.json | ||
|---|---|---|
| 3 ↗ | (On Diff #44620) | this will always need to be bumped after rebasing to the latest master. i'm thinking about a way to automate this but not sure of the best approach. mb run a script that always minor-bumps it on landing if it has not otherwise been changed? Is this the kind of thing that can be done in CI? |
| cashtab/package.json | ||
|---|---|---|
| 3 ↗ | (On Diff #44620) | it was bumping 2 versions |