Page MenuHomePhabricator
Differential D15479

[Cashtab] Apply best practices to improve BalanceHeader integration tests
ClosedPublic
Actions

Authored by bytesofman on Feb 18 2024, 14:42.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC3fba786e754d: [Cashtab] Apply best practices to improve BalanceHeader integration tests
Summary

Clean up these tests with best practices learned from writing all the other tests

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
better-bh-test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27233
Build 54029: Build Diffcashtab-tests
Build 54028: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 18 2024, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 18 2024, 14:42
bytesofman published this revision for review.Feb 18 2024, 14:43
bytesofman added inline comments.
cashtab/src/components/Common/__tests__/BalanceHeader.test.js
45

if you expect it to be in the document, should use getBy... and not queryBy...

Harbormaster completed remote builds in B27233: Diff 45362.Feb 18 2024, 14:46
emack accepted this revision.Feb 19 2024, 06:56
emack added a subscriber: emack.

Accepted with minor nit for consistency

cashtab/src/components/Common/__tests__/BalanceHeader.test.js
197–202

minor nit

This revision is now accepted and ready to land.Feb 19 2024, 06:56
Closed by commit rABC3fba786e754d: [Cashtab] Apply best practices to improve BalanceHeader integration tests (authored by bytesofman). · Explain WhyFeb 19 2024, 21:41
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC3fba786e754d: [Cashtab] Apply best practices to improve BalanceHeader integration tests.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
Common/
__tests__/
76 lines

Diff 45362

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Common/__tests__/BalanceHeader.test.js

Loading...