Page MenuHomePhabricator
Differential D15492

[Cashtab] Combine app integration tests into one file
ClosedPublic
Actions

Authored by bytesofman on Feb 19 2024, 22:23.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCfdde7b20dbba: [Cashtab] Combine app integration tests into one file
Summary

Remove duplicated tests and fix typos in beforeEach

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
combine-app-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27266
Build 54095: Build Diffcashtab-tests
Build 54094: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 19 2024, 22:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2024, 22:23
bytesofman mentioned this in D15460: [Cashtab] Combine App integration tests into one file using now-standardized approach.Feb 19 2024, 22:24
bytesofman updated this revision to Diff 45404.Feb 19 2024, 22:37

rebase, version bump

Harbormaster completed remote builds in B27264: Diff 45401.Feb 19 2024, 22:45
Harbormaster completed remote builds in B27266: Diff 45404.Feb 19 2024, 23:13
bytesofman published this revision for review.Feb 21 2024, 05:03
PiRK added a subscriber: PiRK.Feb 21 2024, 08:13

OK. Confirmed to be move-mostly ( git show --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space)

PiRK accepted this revision.Feb 21 2024, 08:14
This revision is now accepted and ready to land.Feb 21 2024, 08:14
Closed by commit rABCfdde7b20dbba: [Cashtab] Combine app integration tests into one file (authored by bytesofman). · Explain WhyFeb 21 2024, 12:54
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCfdde7b20dbba: [Cashtab] Combine app integration tests into one file.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
__tests__/
261 lines

Diff 45404

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/__tests__/App.test.js

Loading...
View Options

cashtab/src/components/__tests__/AppIntegrations.test.js

Loading...