Add cleanstack check when activating magnetic anomaly
ClosedPublic
Actions

Authored by jasonbcox on Aug 12 2018, 22:39.

Details

Reviewers

Mengerian
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING073d453b4ae7: Add cleanstack check when activating magnetic anomaly
rABC073d453b4ae7: Add cleanstack check when activating magnetic anomaly

Summary

As per suggestion by @dgenr8

Co-authored-by: Amaury Séchet <deadalnix@gmail.com>
Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

Added test cases in abc-magnetic-anomaly-activation.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

activatecleanstack

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/validation.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 3067
Build 4222: Bitcoin ABC Buildbot (legacy)
Build 4221: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 12 2018, 22:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2018, 22:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3067: Diff 4567.Aug 12 2018, 23:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Aug 13 2018, 02:30

This revision is now accepted and ready to land.Aug 13 2018, 02:30

Could you please add a line to release notes?
It saves from having to do a separate Diff for that.

Enforce CLEANSTACK check, starting Nov 15, 2018.

This revision now requires changes to proceed.Aug 13 2018, 15:35

Actually to unblock this, I will do the release notes update in a separate Diff

There are other typos to fix there anyway

This revision is now accepted and ready to land.Aug 13 2018, 17:32

Commandeering to fix comments since Amaury is not available at the moment.

Fixed up comments and added to release-notes

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Aug 13 2018, 19:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3072: Diff 4575.Aug 13 2018, 19:47

jasonbcox requested review of this revision.Aug 13 2018, 19:49

deadalnix accepted this revision.Aug 13 2018, 20:30

This revision is now accepted and ready to land.Aug 13 2018, 20:30

Closed by commit rABC073d453b4ae7: Add cleanstack check when activating magnetic anomaly (authored by deadalnix, committed by jasonbcox). · Explain WhyAug 13 2018, 20:33

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

1 line

test/

functional/

abc-magnetic-anomaly-activation.py

28 lines

Diff 4567

View Options

src/validation.cpp