Page MenuHomePhabricator

Add cleanstack check when activating magnetic anomaly
ClosedPublic

Authored by jasonbcox on Aug 12 2018, 22:39.

Details

Summary

As per suggestion by @dgenr8

Co-authored-by: Amaury Séchet <deadalnix@gmail.com>
Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

Added test cases in abc-magnetic-anomaly-activation.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
activatecleanstack
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 3067
Build 4222: Bitcoin ABC Buildbot (legacy)
Build 4221: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2018, 02:30
Mengerian requested changes to this revision.Aug 13 2018, 15:35
Mengerian added a subscriber: Mengerian.

Could you please add a line to release notes?
It saves from having to do a separate Diff for that.

  • Enforce CLEANSTACK check, starting Nov 15, 2018.
This revision now requires changes to proceed.Aug 13 2018, 15:35

Actually to unblock this, I will do the release notes update in a separate Diff

There are other typos to fix there anyway

This revision is now accepted and ready to land.Aug 13 2018, 17:32
jasonbcox edited reviewers, added: deadalnix; removed: jasonbcox.

Commandeering to fix comments since Amaury is not available at the moment.

Fixed up comments and added to release-notes

This revision is now accepted and ready to land.Aug 13 2018, 20:30
This revision was automatically updated to reflect the committed changes.