Page MenuHomePhabricator

test: add functional test for `-maxtipage` parameter
ClosedPublic

Authored by PiRK on Mar 12 2024, 17:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC23f60e0bd66b: test: add functional test for `-maxtipage` parameter
Summary

This PR adds a missing test for the -maxtipage parameter which controls what is the allowed maximum tip age for leaving IBD.

This is a backport of core#24154 and a partial backport of core#26477
https://github.com/bitcoin/bitcoin/pull/26477/commits/e4be0e9b0661a8af49c4e6d5472804913f04b8fc

The commit from core#26477 should allow catching of the introduced regression when backporting core#25704

Test Plan
cmake .. -GNinja
ninja check-functional

Check that the new test is detected by the test runner and completes successfully.

Diff Detail

Event Timeline

PiRK requested review of this revision.Mar 12 2024, 17:09

fix shebang and permissions, for consistency with all other tests.

bytesofman added inline comments.
test/functional/feature_maxtipage.py
1 ↗(On Diff #46138)

would we change this to 2024?

4 ↗(On Diff #46138)

is this difference in capitalization expected (vs the core PR, nMaxTipAge here and -maxtipage there

image.png (299×1 px, 69 KB)

it is not repeated below, though we do use -maxtipage

Fabien added inline comments.
test/functional/feature_maxtipage.py
1 ↗(On Diff #46138)

This is backport from core, and core added this core in 2022 so the date is correct. This is their copyright

4 ↗(On Diff #46138)

I don't like using the C++ var name in here either, could use -maxtipage instead

7 ↗(On Diff #46138)

dito

This revision is now accepted and ready to land.Mar 13 2024, 08:34