Page MenuHomePhabricator
Differential D1671

Remove various calls to GetSatoshi
ClosedPublic
Actions

Authored by deadalnix on Aug 24 2018, 12:34.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING6ce37f2d773b: Remove various calls to GetSatoshi
rABC6ce37f2d773b: Remove various calls to GetSatoshi
Summary

As per title. Make theloss of precision that may exist in the future explicit.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
varioussats
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3114
Build 4315: Bitcoin ABC Buildbot (legacy)
Build 4314: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 24 2018, 12:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2018, 12:34
teamcity added a subscriber: teamcity.Aug 24 2018, 12:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1672: Remove the Amount::GetSatoshi function.Aug 24 2018, 12:59
teamcity added a comment.Aug 24 2018, 13:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3114: Diff 4633!Aug 24 2018, 13:12
deadalnix retitled this revision from Remove variosu calls to GetSatoshi to Remove various calls to GetSatoshi.Aug 24 2018, 17:40
schancel accepted this revision.Aug 24 2018, 18:55
This revision is now accepted and ready to land.Aug 24 2018, 18:55
deadalnix updated this revision to Diff 4641.Aug 24 2018, 19:28

rebase

teamcity added a comment.Aug 24 2018, 19:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3119: Diff 4641!Aug 24 2018, 20:07
teamcity added a comment.Aug 24 2018, 20:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Closed by commit rABC6ce37f2d773b: Remove various calls to GetSatoshi (authored by deadalnix). · Explain WhyAug 24 2018, 20:12
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
2 lines
6 lines
2 lines
wallet/
test/
2 lines
2 lines

Diff 4633

View Options

src/compressor.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...