Paths

Table of Contentst

Differential D15753

Remove ::minRelayTxFee global
ClosedPublic
Actions

Authored by PiRK on Mar 21 2024, 16:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1f260dda7638: Remove ::minRelayTxFee global

Summary

The -incrementalrelayfee option was removed from Bitcoin ABC in v0.17.2

This is a partial backport of core#25648
https://github.com/bitcoin/bitcoin/pull/25648/commits/fa9cba7afb73c01bd2c8fefd662dfc80dd98c5e8

Depends on D15752

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27993
Build 55534: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 55533: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 21 2024, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2024, 16:06

teamcity edited the summary of this revision. (Show Details)Mar 21 2024, 16:06

PiRK added a child revision: D15754: test: Remove unused cs_main.Mar 21 2024, 16:08

Harbormaster completed remote builds in B27971: Diff 46351.Mar 21 2024, 16:35

rebase

PiRK published this revision for review.Mar 22 2024, 16:03

Harbormaster completed remote builds in B27993: Diff 46384.Mar 22 2024, 16:31

Fabien requested changes to this revision.Mar 25 2024, 09:50

Fabien added a subscriber: Fabien.

Fabien added inline comments.

doc/policy/README.md
5
src/node/interfaces.cpp
666	It's never used ?

This revision now requires changes to proceed.Mar 25 2024, 09:50

PiRK added inline comments.Mar 25 2024, 11:32

src/node/interfaces.cpp
666	It is used in the wallet code only (which does not have direct access to the mempool)

improve policy/README.md

Harbormaster completed remote builds in B28043: Diff 46442.Mar 25 2024, 11:57

Fabien accepted this revision.Mar 25 2024, 12:56

This revision is now accepted and ready to land.Mar 25 2024, 12:56

Closed by commit rABC1f260dda7638: Remove ::minRelayTxFee global (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 25 2024, 13:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1f260dda7638: Remove ::minRelayTxFee global.

Revision Contents
Changeset List

Path

Size

doc/

policy/

README.md

8 lines

src/

init.cpp

11 lines

kernel/

mempool_options.h

7 lines

mempool_args.cpp

14 lines

net_processing.cpp

5 lines

node/

interfaces.cpp

7 lines

policy/

policy.h

4 lines

settings.h

5 lines

settings.cpp

1 line

rpc/

7 lines

7 lines

6 lines

5 lines

15 lines

wallet/

fees.cpp

2 lines

Diff 46384

View Options

doc/policy/README.md

View Options

src/init.cpp

View Options

src/kernel/mempool_options.h

View Options

src/mempool_args.cpp

View Options

src/net_processing.cpp

View Options

src/node/interfaces.cpp

View Options

src/policy/policy.h

View Options

src/policy/settings.h

View Options

src/policy/settings.cpp

View Options

src/rpc/mempool.cpp

View Options

src/rpc/net.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

src/validation.cpp

View Options

Remove ::minRelayTxFee globalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46384

doc/policy/README.md

src/init.cpp

src/kernel/mempool_options.h

src/mempool_args.cpp

src/net_processing.cpp

src/node/interfaces.cpp

src/policy/policy.h

src/policy/settings.h

src/policy/settings.cpp

src/rpc/mempool.cpp

src/rpc/net.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

src/wallet/fees.cpp

Remove ::minRelayTxFee global
ClosedPublic
Actions

Revision Contents
Changeset List