Paths

Table of Contentst

Differential D15790

Move CTxMemPoolEntry class to its own module and inline class's function
ClosedPublic
Actions

Authored by PiRK on Mar 27 2024, 10:56.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1ce42143fd2c: Move CTxMemPoolEntry class to its own module and inline class's function

Summary

The rationale for inlining the functions is that having them in the same translation unit may improve performance of hot loops. See discussion starting at this message:
https://github.com/bitcoin/bitcoin/pull/17786#issuecomment-575673666

This is a backport of core#17786, core#26609 and core#26545

Depends on D15789

Test Plan

ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28085
Build 55715: Build Diff	build-bench · build-debug · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff · build-clang
Build 55714: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 27 2024, 10:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2024, 10:56

teamcity edited the summary of this revision. (Show Details)Mar 27 2024, 10:56

fix file name

@bot build-ubsan

teamcity awarded a token.Mar 27 2024, 11:12

PiRK published this revision for review.Mar 27 2024, 11:12

Harbormaster completed remote builds in B28085: Diff 46499.Mar 27 2024, 11:14

Harbormaster completed remote builds in B28086: Diff 46500.Mar 27 2024, 11:30

PiRK added inline comments.Mar 27 2024, 14:19

src/bench/mempool_eviction.cpp
7 ↗	(On Diff #46500)	the logic adopted by Core wrt to import sorting seems to be that kernel modules are regular local modules, sorted with the others, except in `bitcoin_chainstate.cpp`, `init.cpp` and `validation.cpp` where they are placed at the top. I followed that sorting in this backport.

PiRK added a child revision: D15792: refactor: add kernel/cs_main.*.Mar 27 2024, 14:21

Fabien accepted this revision.Mar 27 2024, 14:21

This revision is now accepted and ready to land.Mar 27 2024, 14:21

Closed by commit rABC1ce42143fd2c: Move CTxMemPoolEntry class to its own module and inline class's function (authored by PiRK). · Explain WhyMar 27 2024, 15:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1ce42143fd2c: Move CTxMemPoolEntry class to its own module and inline class's function.

Revision Contents
Changeset List

Path

Size

src/

bench/

mempool_eviction.cpp

1 line

mempool_stress.cpp

1 line

rpc_mempool.cpp

1 line

kernel/

txmempool_entry.h

154 lines

net_processing.cpp

2 lines

node/

1 line

rpc/

1 line

test/

util/

setup_common.cpp

1 line

128 lines

17 lines

1 line

Diff 46499

src/bench/mempool_eviction.cpp

Loading...

src/bench/mempool_stress.cpp

Loading...

src/bench/rpc_mempool.cpp

Loading...

src/kernel/txmempool_entry.h

Loading...

src/net_processing.cpp

Loading...

src/node/interfaces.cpp

Loading...

src/rpc/mempool.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

src/validation.cpp

Loading...