Differential D1706

Amount(0) => Amount::zero()
ClosedPublic
Actions

Authored by deadalnix on Sep 3 2018, 18:07.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGe49b7c05b8f1: Amount(0) => Amount::zero()
rABCe49b7c05b8f1: Amount(0) => Amount::zero()

Summary

Continue to remove the dependency on a constructor that takes and amount of satoshi as input.

Depends on D1705 and D1703

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

allzerosat

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3175
Build 4437: Bitcoin ABC Buildbot (legacy)
Build 4436: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 3 2018, 18:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2018, 18:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3175: Diff 4727.Sep 3 2018, 18:46

jasonbcox accepted this revision.Sep 4 2018, 06:00

This revision is now accepted and ready to land.Sep 4 2018, 06:00

Closed by commit rABCe49b7c05b8f1: Amount(0) => Amount::zero() (authored by deadalnix). · Explain WhySep 4 2018, 10:13

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

10 lines

2 lines

4 lines

2 lines

6 lines

10 lines

6 lines

2 lines

4 lines

4 lines

policy/

fees.cpp

14 lines

primitives/

transaction.h

2 lines

qt/

bitcoinamountfield.cpp

8 lines

bitcoingui.cpp

4 lines

coincontroldialog.cpp

38 lines

guiutil.cpp

4 lines

overviewpage.cpp

6 lines

receiverequestdialog.cpp

2 lines

recentrequeststablemodel.cpp

2 lines

sendcoinsdialog.cpp

14 lines

sendcoinsentry.cpp

2 lines

test/

uritests.cpp

8 lines

transactiondesc.cpp

8 lines

transactionfilterproxy.cpp

2 lines

transactionrecord.cpp

11 lines

transactiontablemodel.cpp

2 lines

transactionview.cpp

2 lines

walletmodel.cpp

4 lines

walletmodeltransaction.cpp

2 lines

rpc/

2 lines

2 lines

6 lines

2 lines

test/

12 lines

2 lines

2 lines

20 lines

2 lines

8 lines

2 lines

policyestimator_tests.cpp

19 lines

2 lines

26 lines

26 lines

2 lines

txvalidationcache_tests.cpp

2 lines

4 lines

8 lines

8 lines

2 lines

25 lines

wallet/

coincontrol.h

4 lines

rpcwallet.cpp

32 lines

test/

6 lines

2 lines

22 lines

65 lines

Diff 4727

View Options

src/amount.h

View Options

src/bitcoin-tx.cpp

View Options

src/coins.cpp

View Options

src/compressor.cpp

View Options

src/config.h

View Options

src/feerate.cpp

View Options

src/init.cpp

View Options

src/miner.cpp

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/policy/fees.cpp

View Options

src/primitives/transaction.h

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/recentrequeststablemodel.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/sendcoinsentry.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionfilterproxy.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/qt/walletmodeltransaction.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/server.cpp

View Options

src/test/amount_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/main_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/test_bitcoin.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/txmempool.cpp

View Options

src/utilmoneystr.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/wallet/coincontrol.h

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/accounting_tests.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/wallet.h

View Options

Amount(0) => Amount::zero()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4727

src/amount.h

src/bitcoin-tx.cpp

src/coins.cpp

src/compressor.cpp

src/config.h

src/feerate.cpp

src/init.cpp

src/miner.cpp

src/net.cpp

src/net_processing.cpp

src/policy/fees.cpp

src/primitives/transaction.h

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/overviewpage.cpp

src/qt/receiverequestdialog.cpp

src/qt/recentrequeststablemodel.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/test/uritests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionfilterproxy.cpp

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/rawtransaction.cpp

src/rpc/server.cpp

src/test/amount_tests.cpp

src/test/coins_tests.cpp

src/test/compress_tests.cpp

src/test/feerate_tests.cpp

src/test/main_tests.cpp

src/test/miner_tests.cpp

src/test/multisig_tests.cpp

src/test/policyestimator_tests.cpp

src/test/rpc_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/test_bitcoin.cpp

src/test/txvalidationcache_tests.cpp

src/test/util_tests.cpp

src/txmempool.cpp

src/utilmoneystr.cpp

src/validation.h

src/validation.cpp

src/wallet/coincontrol.h

src/wallet/rpcwallet.cpp

src/wallet/test/accounting_tests.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Amount(0) => Amount::zero()
ClosedPublic
Actions

Revision Contents
Changeset List