refactor: move CBlockIndex#ToString() from header to implementation
ClosedPublic
Actions

Authored by PiRK on Apr 29 2024, 11:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

which allows dropping tinyformat.h from the header file.

Depends on D16072

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Branch

pr25023

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28790
Build 57118: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57117: arc lint + arc unit

PiRK created this revision.Apr 29 2024, 11:21

PiRK requested review of this revision.Apr 29 2024, 11:21

Fabien resigned from this revision.Apr 29 2024, 13:01

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/chain.h
19	unrelated ?

Fabien requested changes to this revision.Apr 29 2024, 13:01

This revision now requires changes to proceed.Apr 29 2024, 13:01

PiRK requested review of this revision.Apr 29 2024, 13:55

PiRK added inline comments.

src/chain.h
19	It is semi-related imo. It should have been removed in D6988 when CBlockIndex was moved to its own module. It was probably initially there for `CBlockIndex::ToString()`