Do not use Amount constructor taking satoshi as aprameter in the test code.
ClosedPublic
Actions

Authored by deadalnix on Sep 5 2018, 14:24.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1d6f7c286305: Do not use Amount constructor taking satoshi as aprameter in the test code.
rABC1d6f7c286305: Do not use Amount constructor taking satoshi as aprameter in the test code.

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

satbuildtest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3202
Build 4491: Bitcoin ABC Buildbot (legacy)
Build 4490: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 5 2018, 14:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2018, 14:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1723: Make the constructor taking satoshi as parameter from the Amount class private.Sep 5 2018, 14:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3199: Diff 4770.Sep 5 2018, 15:01

jasonbcox requested changes to this revision.Sep 5 2018, 16:49

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/main_tests.cpp
57 ↗	(On Diff #4770)	ULL -> LL, as casting unsigned immediately to signed is pointless

This revision now requires changes to proceed.Sep 5 2018, 16:49

ULL -> LL

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3202: Diff 4775.Sep 5 2018, 19:15

jasonbcox accepted this revision.Sep 5 2018, 22:22

This revision is now accepted and ready to land.Sep 5 2018, 22:22

Closed by commit rABC1d6f7c286305: Do not use Amount constructor taking satoshi as aprameter in the test code. (authored by deadalnix). · Explain WhySep 6 2018, 10:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

23 lines

16 lines

2 lines

12 lines

4 lines

7 lines

17 lines

2 lines

policyestimator_tests.cpp

4 lines

script_tests.cpp

6 lines

sighash_tests.cpp

2 lines

transaction_tests.cpp

14 lines

util_tests.cpp

2 lines

wallet/

test/

accounting_tests.cpp

2 lines

Diff 4775

View Options

src/test/amount_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/main_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/wallet/test/accounting_tests.cpp

Do not use Amount constructor taking satoshi as aprameter in the test code.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4775

src/test/amount_tests.cpp

src/test/coins_tests.cpp

src/test/compress_tests.cpp

src/test/feerate_tests.cpp

src/test/main_tests.cpp

src/test/mempool_tests.cpp

src/test/miner_tests.cpp

src/test/multisig_tests.cpp

src/test/policyestimator_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/transaction_tests.cpp

src/test/util_tests.cpp

src/wallet/test/accounting_tests.cpp

Do not use Amount constructor taking satoshi as aprameter in the test code.
ClosedPublic
Actions

Revision Contents
Changeset List