[avalanche] pass the processor to Chainstate::ConnectTip
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd1aed6b0b789: [avalanche] pass the processor to Chainstate::ConnectTip

Summary

One step in remove access to the g_avalanche global in Chainstate code.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29198
Build 57932: Build Diff	lint-circular-dependencies · build-debug · build-clang-tidy · build-diff · build-without-wallet · build-clang
Build 57931: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 4 2024, 10:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2024, 10:08

PiRK requested review of this revision.Jun 4 2024, 10:08

PiRK added a child revision: D16266: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step].Jun 4 2024, 10:11

Harbormaster completed remote builds in B29198: Diff 48078.Jun 4 2024, 10:22

Fabien accepted this revision.Jun 4 2024, 11:31

This revision is now accepted and ready to land.Jun 4 2024, 11:31

Closed by commit rABCd1aed6b0b789: [avalanche] pass the processor to Chainstate::ConnectTip (authored by PiRK). · Explain WhyJun 4 2024, 15:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd1aed6b0b789: [avalanche] pass the processor to Chainstate::ConnectTip.

PiRK mentioned this in D16263: [avalanche] don't use global g_avalanche in Chainstate code.Jun 4 2024, 15:21

Revision Contents
Changeset List

Path

Size

src/

validation.h

6 lines

validation.cpp

9 lines

Diff 48078

View Options

src/validation.h