Move validation of consensus rules relative to transaction in consensus/tx_verify.cpp
ClosedPublic
Actions

Authored by deadalnix on Sep 7 2018, 12:16.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf0cc8b19c81a: Move validation of consensus rules relative to transaction in…
rABCf0cc8b19c81a: Move validation of consensus rules relative to transaction in…

Summary

This diff is similar in spirit to core PR8329 but is not a direct backport because consensus rules between BTC and BCH differs in such a manner it is not directly possible.

Depends on D1738

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txverify

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3234
Build 4555: Bitcoin ABC Buildbot (legacy)
Build 4554: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 7 2018, 12:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2018, 12:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3228: Diff 4815.Sep 7 2018, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3234: Diff 4826.Sep 9 2018, 11:17

schancel accepted this revision.Sep 10 2018, 19:13

This revision is now accepted and ready to land.Sep 10 2018, 19:13

Closed by commit rABCf0cc8b19c81a: Move validation of consensus rules relative to transaction in… (authored by deadalnix). · Explain WhySep 10 2018, 19:51

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.Jul 5 2019, 18:44

nakihito mentioned this in D4042: Merge #11220: Check specific validation error in miner tests.Sep 11 2019, 17:50

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

Makefile.am

2 lines

consensus/

tx_verify.h

102 lines

tx_verify.cpp

341 lines

miner.cpp

1 line

test/

miner_tests.cpp

1 line

script_P2SH_tests.cpp

1 line

sighash_tests.cpp

2 lines

sigopcount_tests.cpp

2 lines

transaction_tests.cpp

3 lines

txmempool.cpp

1 line

validation.h

73 lines

validation.cpp

327 lines

wallet/

walletdb.cpp

2 lines

Diff 4826

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/consensus/tx_verify.h

View Options

src/consensus/tx_verify.cpp

View Options

src/miner.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

Move validation of consensus rules relative to transaction in consensus/tx_verify.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4826

src/CMakeLists.txt

src/Makefile.am

src/consensus/tx_verify.h

src/consensus/tx_verify.cpp

src/miner.cpp

src/test/miner_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/sighash_tests.cpp

src/test/sigopcount_tests.cpp

src/test/transaction_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

src/wallet/walletdb.cpp

Move validation of consensus rules relative to transaction in consensus/tx_verify.cpp
ClosedPublic
Actions

Revision Contents
Changeset List