Page MenuHomePhabricator

Add HashWriter without ser-type and ser-version and use it where possible
ClosedPublic

Authored by Fabien on Jul 15 2024, 21:16.

Details

Summary
The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version.
So do this here for HashWriter. CHashWriter remains in places where it is not yet possible.

Backport of core#25331 and core#28341.

Test Plan
ninja all check-extended

Event Timeline

Fabien requested review of this revision.Jul 15 2024, 21:16
roqqit requested changes to this revision.Jul 15 2024, 22:46
roqqit added a subscriber: roqqit.
roqqit added inline comments.
src/avalanche/processor.cpp
494 ↗(On Diff #48638)

Please cleanup these empty-line semicolons throughout the diff. Changes look good otherwise.

This revision now requires changes to proceed.Jul 15 2024, 22:46
src/avalanche/processor.cpp
494 ↗(On Diff #48638)

Ah, I knew I created these double semicolons during copy pasting, but wanted to see if the linter will catch it, which it did... But I missed that it added it back on a newline :(

Fix extraneous semicolon

This revision is now accepted and ready to land.Jul 16 2024, 20:32